Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ui.inlineCreate for relationships submitting the parent form of nested relationship fields #8914

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Nov 15, 2023

As described, this pull request stops the parent form submitting when you create an item when using displayMode: 'cards' and inlineCreate.

Nested forms in HTML5 aren't supported - to my knowledge - so I don't know what this was expected to do, but the previous behavior regularly wiped your input fields which can be painful.

@dcousens dcousens marked this pull request as ready for review November 15, 2023 03:45
@dcousens dcousens requested a review from borisno2 November 15, 2023 03:45
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f54723:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens self-assigned this Nov 15, 2023
@dcousens dcousens merged commit 25a6586 into main Nov 15, 2023
58 checks passed
@dcousens dcousens deleted the fix-inline-create branch November 15, 2023 04:12
@dcousens dcousens mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants